junrao commented on code in PR #18727: URL: https://github.com/apache/kafka/pull/18727#discussion_r1934405834
########## clients/src/main/resources/common/message/ProduceRequest.json: ########## @@ -44,7 +47,7 @@ // transaction V2 (KIP_890 part 2) is enabled, the produce request will also include the function for a // AddPartitionsToTxn call. If V2 is disabled, the client can't use produce request version higher than 11 within // a transaction. - "validVersions": "3-12", + "validVersions": "0-12", Review Comment: It seems that `UNSUPPORTED_VERSION` was added in 0.10.0 https://github.com/apache/kafka/pull/986/files#diff-0ae188e241ee35148145e7e04ed2acb3c20356650194f3603811c51b886ebe20. Produce v0/v1 already existed in 0.9. So, even if we send `UNSUPPORTED_VERSION` in the error, the 0.9 client won't be able to understand it. So, it really only helps with Produce v2 request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
