stanislavkozlovski commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1932959065


##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -374,6 +374,10 @@ class KafkaApis(val requestChannel: RequestChannel,
    */
   def handleProduceRequest(request: RequestChannel.Request, requestLocal: 
RequestLocal): Unit = {
     val produceRequest = request.body[ProduceRequest]
+    if (produceRequest.version <= 2) {

Review Comment:
   should there be a test/documentation explaining why this is done? otherwise 
could easily get swept away in a future change 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to