chia7712 commented on code in PR #18547:
URL: https://github.com/apache/kafka/pull/18547#discussion_r1927249146
##########
server/src/main/java/org/apache/kafka/server/config/ZkConfigs.java:
##########
@@ -22,23 +22,15 @@
import java.util.Map;
import java.util.stream.Collectors;
-import static org.apache.kafka.common.config.ConfigDef.Importance.HIGH;
import static org.apache.kafka.common.config.ConfigDef.Importance.LOW;
import static org.apache.kafka.common.config.ConfigDef.Importance.MEDIUM;
-import static org.apache.kafka.common.config.ConfigDef.Range.atLeast;
import static org.apache.kafka.common.config.ConfigDef.Type.BOOLEAN;
-import static org.apache.kafka.common.config.ConfigDef.Type.INT;
import static org.apache.kafka.common.config.ConfigDef.Type.LIST;
import static org.apache.kafka.common.config.ConfigDef.Type.PASSWORD;
import static org.apache.kafka.common.config.ConfigDef.Type.STRING;
public final class ZkConfigs {
Review Comment:
open https://issues.apache.org/jira/browse/KAFKA-18631 to remove this config
file
##########
server/src/main/java/org/apache/kafka/server/config/ZkConfigs.java:
##########
@@ -152,11 +132,6 @@ public final class ZkConfigs {
}
public static final ConfigDef CONFIG_DEF = new ConfigDef()
- .define(ZK_CONNECT_CONFIG, STRING, null, HIGH, ZK_CONNECT_DOC)
Review Comment:
Could you please add those configs to `zk2kraft.html`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
