m1a2st commented on code in PR #18547:
URL: https://github.com/apache/kafka/pull/18547#discussion_r1926663158
##########
core/src/main/scala/kafka/server/Server.scala:
##########
@@ -69,13 +69,7 @@ object Server {
): KafkaMetricsContext = {
val contextLabels = new java.util.HashMap[String, Object]
contextLabels.put(ClusterIdLabel, clusterId)
-
- if (config.usesSelfManagedQuorum) {
- contextLabels.put(NodeIdLabel, config.nodeId.toString)
- } else {
- contextLabels.put(BrokerIdLabel, config.brokerId.toString)
- }
-
+ contextLabels.put(BrokerIdLabel, config.brokerId.toString)
Review Comment:
In
[ServerTest.scala](https://github.com/apache/kafka/pull/18547/files#diff-65b84c35e763043ec7de1cb79d789ce336262cd27cdc63502cdf2b7cb4553296)
will test this bug, I think we won't need to add a new test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
