jolshan commented on code in PR #18604:
URL: https://github.com/apache/kafka/pull/18604#discussion_r1925801892


##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -600,6 +600,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
    */
   def hasOngoingTransaction(producerId: Long, producerEpoch: Short): Boolean = 
lock synchronized {
     val entry = producerStateManager.activeProducers.get(producerId)
+    // With transactions V2, if we see a future epoch, we are likely in the 
process of completing the previous transaction.

Review Comment:
   Hmmm. We can see a future epoch in the case where the next transaction has 
started while the previous one is completing. For V2 this can happen due to the 
reordering of handling the produce and add partitions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to