artemlivshits commented on code in PR #18604:
URL: https://github.com/apache/kafka/pull/18604#discussion_r1920926859
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1052,7 +1057,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private def batchMissingRequiredVerification(batch: MutableRecordBatch,
requestVerificationGuard: VerificationGuard): Boolean = {
-
producerStateManager.producerStateManagerConfig().transactionVerificationEnabled()
&& !batch.isControlBatch &&
+
producerStateManager.producerStateManagerConfig().transactionVerificationEnabled()
&&
Review Comment:
No, this is good. I'm just thinking if having this function makes the code
better or worse -- it's really called exactly from one place and looks like the
order of checks is important and can lead to subtle bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
