chirag-wadhwa5 commented on code in PR #18514:
URL: https://github.com/apache/kafka/pull/18514#discussion_r1917854177
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -456,6 +456,17 @@ public CompletableFuture<Void> maybeInitialize() {
stateBatch.lastOffset(),
RecordState.forId(stateBatch.deliveryState()), stateBatch.deliveryCount(),
null);
cachedState.put(stateBatch.firstOffset(), inFlightBatch);
}
+
+ long initialOffset = startOffset;
Review Comment:
Ohh yes, there was a minor issue. The if check should have been `if
(initialOffset != currentStateBatch.firstOffset()) ` instead of `if
(startOffset != currentStateBatch.firstOffset()) `. I have made the change.
Also, the case 2 described above doesn't need any changes, because the
cachedState is already populated with the response from readState result.
Thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
