chirag-wadhwa5 commented on code in PR #18514:
URL: https://github.com/apache/kafka/pull/18514#discussion_r1914366165
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -456,6 +456,17 @@ public CompletableFuture<Void> maybeInitialize() {
stateBatch.lastOffset(),
RecordState.forId(stateBatch.deliveryState()), stateBatch.deliveryCount(),
null);
cachedState.put(stateBatch.firstOffset(), inFlightBatch);
}
+
+ long initialOffset = startOffset;
Review Comment:
Thanks for the review. I have a test case present here, which I believe
tests exactly the case you mentioned above. Can you pls take a look at that. I
do have the check `if (startOffset != currentStateBatch.firstOffset())` inside
the loop, which would not result in adding any state batch when initialOffset =
21, and would directly move the initialOffset to 26.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
