divijvaidya commented on code in PR #18435:
URL: https://github.com/apache/kafka/pull/18435#discussion_r1907586036
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java:
##########
@@ -280,6 +281,9 @@ public void updateFailed(Throwable exception) {
if (exception instanceof AuthenticationException) {
Review Comment:
I understand that this is increasing the scope of the JIRA. What I am trying
to suggest here will help us prevent such problems in future for cases where a
client retries on a fatal exception. If we have a utility method, we can
consolidate the logic of what is considered fatal at one place and
existing/future calls to server APIs can use that utility to handle exceptions.
It will prevent bugs in future if new authors can use the utility method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
