divijvaidya commented on code in PR #18435:
URL: https://github.com/apache/kafka/pull/18435#discussion_r1907082720


##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java:
##########
@@ -280,6 +281,9 @@ public void updateFailed(Throwable exception) {
         if (exception instanceof AuthenticationException) {
             log.warn("Metadata update failed due to authentication error", 
exception);
             this.fatalException = (ApiException) exception;
+        } else if (exception instanceof ClusterAuthorizationException) {

Review Comment:
   should this be `AuthorizationException` here since all authZ exceptions are 
non-retriable?



##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java:
##########
@@ -280,6 +281,9 @@ public void updateFailed(Throwable exception) {
         if (exception instanceof AuthenticationException) {

Review Comment:
   Please add a function `isFatalException` and add AuthenticationException, 
AuthorizationException, SecurityDisabledException, 
UnsupportedEndpointTypeException, UnsupportedForMessageFormatException, 
UnsupportedVersionException etc.
   
   You can add this function in `RequestUtils` class. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to