FrankYang0529 commented on code in PR #18435: URL: https://github.com/apache/kafka/pull/18435#discussion_r1907173239
########## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java: ########## @@ -280,6 +281,9 @@ public void updateFailed(Throwable exception) { if (exception instanceof AuthenticationException) { Review Comment: Thanks for the review. This Jira would like to focus on fatal exception for metadata call in Admin. IIRC, The `SecurityDisabledException` is used in create / delete ACLs and `UnsupportedForMessageFormatException` is used in produce request, so I don't add them. Also, in `UnsupportedVersionException`, it logs different message for bootstrap and controller node, so I don't encapsulate all exceptions in a utility function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org