chia7712 commented on code in PR #18185:
URL: https://github.com/apache/kafka/pull/18185#discussion_r1896524994
##########
tests/kafkatest/tests/connect/connect_distributed_test.py:
##########
@@ -563,7 +563,14 @@ def test_dynamic_logging(self, metadata_quorum):
# have been discarded
self._restart_worker(worker)
restarted_loggers = self.cc.get_all_loggers(worker)
- assert initial_loggers == restarted_loggers
+
Review Comment:
around line#555 the check needs to be modified as well:
```
# Make sure no changes to loggers outside the affected namespace
have taken place
all_loggers = self.cc.get_all_loggers(worker)
for logger, level in all_loggers.items():
if not logger.startswith(namespace):
assert level['level'] == new_root
if level['last_modified'] is not None:
assert root_request_time <= level['last_modified'] <
request_time
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
