chia7712 commented on code in PR #18185:
URL: https://github.com/apache/kafka/pull/18185#discussion_r1896512363
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##########
@@ -203,7 +201,7 @@ private void setLevel(org.apache.logging.log4j.Logger
logger, Level level) {
LoggerConfig loggerConfig =
context.getConfiguration().getLoggerConfig(loggerName);
Level currentLevel = loggerConfig.getLevel();
- if (level.equals(currentLevel)) {
+ if (lastModifiedTimes.containsKey(loggerName) &&
level.equals(currentLevel)) {
Review Comment:
As we discussed off-line, the check of existence `lastModifiedTimes` can be
removed as we should revise the test behaviour to match log4j2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
