chia7712 commented on code in PR #18185:
URL: https://github.com/apache/kafka/pull/18185#discussion_r1888963471
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##########
@@ -105,14 +108,10 @@ public synchronized LoggerLevel level(String logger) {
public synchronized Map<String, LoggerLevel> allLevels() {
Map<String, LoggerLevel> result = new TreeMap<>();
- currentLoggers().stream()
- .filter(logger -> !logger.getLevel().equals(Level.OFF))
- .forEach(logger -> result.put(logger.getName(),
loggerLevel(logger)));
-
- org.apache.logging.log4j.Logger root = rootLogger();
- if (!root.getLevel().equals(Level.OFF)) {
- result.put(ROOT_LOGGER_NAME, loggerLevel(root));
- }
+ currentLoggers()
Review Comment:
It seems the implementation of `currentLoggers` is not correct - it should
return all registered logger rather than configured logger. For example:
`context.getLoggerRegistry().getLoggers()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
