VedarthConfluent commented on PR #17705: URL: https://github.com/apache/kafka/pull/17705#issuecomment-2488517083
Hey @fvaleri First of all thanks a lot for working on this. File Input is supposed to be optional. We can consider adding a message explicitly that file input is not being used when it is not detected. > The env vars is appended to the default or user provided configuration file, so it can be a new configuration or an override of an existing one - This approach is ideal for a scenario where the configs do not interfere or impact each other. - Unfortunately in kafka there seems to be some configs that cannot be used together. - Putting a default config file and allowing users to append on top of it may result in a scenario where user may not be aware of what the exact default configs are so may get surprised when a config related error is thrown. - The ideal way to use env variable powered properties is via docker compose, which allows users to see all the configs that they actually need. - In case the users want to have a common set of configs that they want to apply, they can use file input. For example:- If we use your changes as it is, then we will not be able to run the kafka server in Controller mode. The reason is that currently we use the server.properties file for default config, which assumes that the kafka server is supposed to be run in combined mode. If we want to be able to append to the default properties, then we will need to make the container aware about what mode is it supposed to run on and use the appropriate default config. This will require significant changes to the behaviour of docker image, as currently the docker container is not aware of the properties and just passes them on to the server. There always is a possibility that some user provided config might not work with the default config (cmiiw), so we will always be at risk of running into config errors if we append user configs over default configs. We can consider an enhancement to remove the duplicated properties, but that is a separate issue. Even if we de-duplicate the configs, if default configs don't work with user provided configs, the error scenario will still occur. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
