fvaleri commented on PR #17705: URL: https://github.com/apache/kafka/pull/17705#issuecomment-2486077040
> I can raise a PR to fix the documentation That would be great. Thanks. > I agree that this may not provide the best user experience, but it helps eliminate confusion that could arise from default configurations when users provide their own configurations. Can you elaborate more on this? The env vars is appended to the default or user provided configuration file, so it can be a new configuration or an override of an existing one. What could be the problem with this approach? A better approach would be to implement replace logic, that would produce a clean configuration file (without duplicated properties). Testcontainers seems to already support setting env vars on official Kafka images the way one would expect: https://github.com/mimaison/metrics-reporter/commit/78a7e4884d3d20c589d6798409d6e085a6666331#diff-2c4376994877e77f6cf5220a3603feeb95b19a458924486fe5b63c2c8150c8c2R39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
