fvaleri commented on code in PR #17705:
URL: https://github.com/apache/kafka/pull/17705#discussion_r1846123240
##########
core/src/test/scala/unit/kafka/docker/KafkaDockerWrapperTest.scala:
##########
@@ -109,25 +109,6 @@ class KafkaDockerWrapperTest {
assertEquals(expected, actual)
}
- @Test
- def testPrepareServerConfigsWithEmptyMountedFile(): Unit = {
Review Comment:
> Why do we remove this test?
This was testing the empty user config, where we were silently switching to
default config. As explained in the patch description, I changed this behavior
to make it fail so the user can quickly spot the configuration issue. Wdyt?
> I expect we should have a test for envVars, could you help add one?
I think the following tests are also testing the env var config mechanism.
Let me see if I can add a new one or maybe just improve them.
- testGetServerConfigsFromEnv
- testPrepareServerConfigs
- testPrepareServerConfigsWithoutMountedFile
- testPrepareServerConfigsWithoutEnvVariables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
