CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1834910462
########## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ########## @@ -85,7 +105,7 @@ class AddPartitionsToTxnManager( private val verificationFailureRate = metricsGroup.newMeter(VerificationFailureRateMetricName, "failures", TimeUnit.SECONDS) private val verificationTimeMs = metricsGroup.newHistogram(VerificationTimeMsMetricName) - def verifyTransaction( + def addOrVerifyTransaction( Review Comment: Are you referring to the UT failures for the previous closed PR? We still have the problem with testBumpTransactionalEpochAfterInvalidProducerIdMapping after the epoch bump change. I included a fix in the TransactionManager which reset the epochBumpRequired if received a success InitProducerId response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
