jolshan commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1847078885
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -1123,8 +1129,12 @@ private TxnOffsetCommitHandler
txnOffsetCommitHandler(TransactionalRequestResult
pendingTxnOffsetCommits,
groupMetadata.memberId(),
groupMetadata.generationId(),
- groupMetadata.groupInstanceId()
+ groupMetadata.groupInstanceId(),
+ isTransactionV2Enabled()
);
+ if (result == null) {
Review Comment:
Should we leave a comment for this method specifying that if result is null,
we are using tv2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
