rreddy-22 commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1829874541
##########
clients/src/main/java/org/apache/kafka/common/requests/TxnOffsetCommitRequest.java:
##########
@@ -70,21 +72,35 @@ public Builder(final String transactionalId,
final String memberId,
final int generationId,
final Optional<String> groupInstanceId) {
+ this(transactionalId, consumerGroupId, producerId, producerEpoch,
pendingTxnOffsetCommits, memberId, generationId, groupInstanceId, true);
Review Comment:
I feel like we shouldn't set isTransactionV2Enabled to true by default, can
we make it a compulsory argument when we build the request so avoid unexpected
behavior especially in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
