kirktrue commented on PR #17244:
URL: https://github.com/apache/kafka/pull/17244#issuecomment-2378089979

   > Yes, it's there (not only that error, all errors found in metadata). But 
note that we shouldn't "skip the enqueuing" down there, because at the network 
layer all we know is that we got an error in a MetadataResponse, so we should 
propagate it no matter what, because we cannot differentiate down there if the 
InvalidTopicException we got will end up showing-up in the api call to 
unsubscribe (we want to swallow it), or if it will end up in the api call to 
poll (we want to throw it).
   
   So at the point that the `NetworkClientDelegate` sees the 
`InvalidTopicException`, it lacks the necessary context to make a decision 
about ignoring it or passing it on.
   
   That makes sense. Thanks for your patience and explanation :smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to