lianetm commented on code in PR #17244:
URL: https://github.com/apache/kafka/pull/17244#discussion_r1777568741


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1279,7 +1281,7 @@ private void releaseAssignmentAndLeaveGroup(final Timer 
timer) {
         UnsubscribeEvent unsubscribeEvent = new 
UnsubscribeEvent(calculateDeadlineMs(timer));
         applicationEventHandler.add(unsubscribeEvent);
         try {
-            processBackgroundEvents(unsubscribeEvent.future(), timer);
+            processBackgroundEvents(unsubscribeEvent.future(), timer, e -> e 
instanceof InvalidTopicException);

Review Comment:
   No I would say. It's already a KafkaException (we do wrap what it's not), 
and it's simply created here and passed into the event on the other link you 
shared.
   
https://github.com/apache/kafka/blob/18340c973378610cd5930974201088b6aca8a8ad/clients/src/main/java/org/apache/kafka/clients/Metadata.java#L648



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to