lianetm commented on PR #17244: URL: https://github.com/apache/kafka/pull/17244#issuecomment-2377648715
> Is [this](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java#L149-L155) where the event is getting enqueued? Yes, it's there (not only that error, all errors found in metadata). But note that we shouldn't "skip the enqueuing" down there, because at the network layer all we know is that we got an error in a MetadataResponse, so we should propagate it no matter what, because we cannot differentiate down there if the InvalidTopicException we got will end up showing-up in the api call to unsubscribe (we want to swallow it), or if it will end up in the api call to poll (we want to throw it). This: 1. subscribe(invalid) + unsubscribe => should swallow the InvalidTopic it may get when processingBackgroundEvents in the unsubscribe 2. subscribe(invalid) + poll => should throw want to throw the same InvalidTopic it gets when processingBackgroundEvents Makes sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
