muralibasani commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1734129356
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -889,6 +901,11 @@ public class StreamsConfig extends AbstractConfig {
LogAndFailExceptionHandler.class.getName(),
Importance.MEDIUM,
DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_DOC)
+ .define(DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG,
+ Type.CLASS,
+ LogAndFailExceptionHandler.class.getName(),
Review Comment:
Currently we have set default values for both old and new config which is
LogAndFailExceptionHandler.class.
With this situation, even if user configures a different handler to old
config, LogAndFailExceptionHandler will be picked up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
