mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1733653179


##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -555,12 +555,24 @@ public class StreamsConfig extends AbstractConfig {
 
     /** {@code default.deserialization.exception.handler} */
     @SuppressWarnings("WeakerAccess")
+    @Deprecated
     public static final String 
DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG = 
"default.deserialization.exception.handler";
+    @Deprecated
     public static final String 
DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_DOC = "Exception handling class 
that implements the 
<code>org.apache.kafka.streams.errors.DeserializationExceptionHandler</code> 
interface.";
 
+    /** {@code deserialization.exception.handler} */
+    @SuppressWarnings("WeakerAccess")
+    public static final String DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG 
= "deserialization.exception.handler";
+
+    protected static final String DESERIALIZATION_EXCEPTION_HANDLER_CLASS_DOC 
= "Exception handling class that implements the 
<code>org.apache.kafka.streams.errors.DeserializationExceptionHandler</code> 
interface.";

Review Comment:
   For this case, let's use package private.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to