mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1735355654
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -918,12 +938,7 @@ public class StreamsConfig extends AbstractConfig {
Type.CLASS,
DefaultProductionExceptionHandler.class.getName(),
Importance.MEDIUM,
- DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_DOC)
- .define(PROCESSING_EXCEPTION_HANDLER_CLASS_CONFIG,
- Type.CLASS,
- LogAndFailProcessingExceptionHandler.class.getName(),
- Importance.MEDIUM,
- PROCESSING_EXCEPTION_HANDLER_CLASS_DOC)
+ PRODUCTION_EXCEPTION_HANDLER_CLASS_DOC)
Review Comment:
Both are the same so it does not really matter too much. Just feels itchy to
use the new `_DOC` variable for the old config. -- And the fact that the new
one is private should not matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
