junrao commented on code in PR #16132:
URL: https://github.com/apache/kafka/pull/16132#discussion_r1678259652
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -320,7 +324,10 @@ public Optional<String> serverConfigName(String
configName) {
.define(TopicConfig.LOCAL_LOG_RETENTION_MS_CONFIG, LONG,
DEFAULT_LOCAL_RETENTION_MS, atLeast(-2), MEDIUM,
TopicConfig.LOCAL_LOG_RETENTION_MS_DOC)
.define(TopicConfig.LOCAL_LOG_RETENTION_BYTES_CONFIG, LONG,
DEFAULT_LOCAL_RETENTION_BYTES, atLeast(-2), MEDIUM,
- TopicConfig.LOCAL_LOG_RETENTION_BYTES_DOC);
+ TopicConfig.LOCAL_LOG_RETENTION_BYTES_DOC)
+ .define(TopicConfig.REMOTE_LOG_DISABLE_POLICY_CONFIG, STRING,
TopicConfig.REMOTE_LOG_DISABLE_POLICY_RETAIN,
Review Comment:
Do we plan to finish implementing this feature in 3.9, which is a short
release? If not, perhaps we should define the new config with `defineInternal`
so that it's not exposed to the end user until the feature is implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
