showuon commented on code in PR #16132:
URL: https://github.com/apache/kafka/pull/16132#discussion_r1669550818
##########
metadata/src/main/java/org/apache/kafka/metadata/KafkaConfigSchema.java:
##########
@@ -166,9 +166,11 @@ public Map<String, ConfigEntry>
resolveEffectiveTopicConfigs(
ConfigDef configDef =
configDefs.getOrDefault(ConfigResource.Type.TOPIC, EMPTY_CONFIG_DEF);
HashMap<String, ConfigEntry> effectiveConfigs = new HashMap<>();
for (ConfigDef.ConfigKey configKey : configDef.configKeys().values()) {
- ConfigEntry entry = resolveEffectiveTopicConfig(configKey,
staticNodeConfig,
- dynamicClusterConfigs, dynamicNodeConfigs,
dynamicTopicConfigs);
- effectiveConfigs.put(entry.name(), entry);
+ if (!configKey.internalConfig) {
Review Comment:
Could I know why we should do this change? For broken tests? I'm not 100%
sure if this change changes some behavior or not. If it's for broken tests, I'd
suggest we make the config as non-internal config. We plan to make it complete
in v3.9.0 anyway. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
