clolov commented on code in PR #16132:
URL: https://github.com/apache/kafka/pull/16132#discussion_r1670963737
##########
metadata/src/main/java/org/apache/kafka/metadata/KafkaConfigSchema.java:
##########
@@ -166,9 +166,11 @@ public Map<String, ConfigEntry>
resolveEffectiveTopicConfigs(
ConfigDef configDef =
configDefs.getOrDefault(ConfigResource.Type.TOPIC, EMPTY_CONFIG_DEF);
HashMap<String, ConfigEntry> effectiveConfigs = new HashMap<>();
for (ConfigDef.ConfigKey configKey : configDef.configKeys().values()) {
- ConfigEntry entry = resolveEffectiveTopicConfig(configKey,
staticNodeConfig,
- dynamicClusterConfigs, dynamicNodeConfigs,
dynamicTopicConfigs);
- effectiveConfigs.put(entry.name(), entry);
+ if (!configKey.internalConfig) {
Review Comment:
Yup, this was breaking a test in one of the previous test runs on the PR.
Happy to go with not defining the configuration as internal 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
