chia7712 commented on code in PR #16017:
URL: https://github.com/apache/kafka/pull/16017#discussion_r1618192241
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -208,7 +209,8 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
return new
NetworkClientDelegate.PollResult(heartbeatRequestState.heartbeatIntervalMs,
Collections.singletonList(leaveHeartbeat));
}
- boolean heartbeatNow = membershipManager.shouldHeartbeatNow() &&
!heartbeatRequestState.requestInFlight();
+// boolean heartbeatNow = membershipManager.shouldHeartbeatNow() &&
!heartbeatRequestState.requestInFlight();
+ boolean heartbeatNow = membershipManager.state() ==
MemberState.LEAVING || membershipManager.shouldHeartbeatNow() &&
!heartbeatRequestState.requestInFlight();
Review Comment:
Could we add comments to list the cases about `heartbeatNow=true`? the
condition check is a bit complicated to me :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
