lianetm commented on PR #16017: URL: https://github.com/apache/kafka/pull/16017#issuecomment-2135704863
Great news! Thanks for the updates @frankvicky, I'll take a look. What exactly are you after regarding the integration test? I expect this bit would be tricky to test at that level, given it depends on many time situations from broker/client that need to align (HB response not received, trigger leave then, and checking that the request would actually happen would require some kind of validation of rebalance happening within the inflight time-frame). Maybe there's an easy and effective way I'm missing, but I would say the unit tests at the HB manager level should give us good confidence on this change. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
