philipnee commented on code in PR #14390:
URL: https://github.com/apache/kafka/pull/14390#discussion_r1361278043
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -142,9 +142,26 @@ public void transitionToFailed() {
transitionTo(MemberState.FAILED);
}
+ @Override
+ public void tryJoin() {
+ resetEpoch();
+ transitionTo(MemberState.UNJOINED);
+ }
+
+ @Override
+ public void leaveGroup() {
+ resetEpoch();
Review Comment:
instead of reset the Epoch, which seems confusing, I made the epcoh =
OptionalInt.empty() so that when the member tries to send a commit, it won't
send the epoch after leaving the group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
