lianetm commented on code in PR #14390:
URL: https://github.com/apache/kafka/pull/14390#discussion_r1358432414
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -231,25 +246,23 @@ public NetworkClientDelegate.UnsentRequest
toUnsentRequest() {
private class OffsetFetchRequestState extends RequestState {
public final Set<TopicPartition> requestedPartitions;
- public final GroupState.Generation requestedGeneration;
- private final CompletableFuture<Map<TopicPartition,
OffsetAndMetadata>> future;
+ public CompletableFuture<Map<TopicPartition, OffsetAndMetadata>>
future;
+
public OffsetFetchRequestState(final Set<TopicPartition> partitions,
- final GroupState.Generation generation,
Review Comment:
My comment is really only to make sure we are on the same page regarding the
need of epoch here. But ok if we don't include the changes in this PR, because
I also have them in the changes for OffsetFetch v9 that will follow this. I
added id and epoch here not only to send it in the request, but also to
differentiate the requests that will be retried.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
