lianetm commented on code in PR #14390:
URL: https://github.com/apache/kafka/pull/14390#discussion_r1358311725
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -173,19 +179,22 @@ CompletableFuture<Void> sendAutoCommit(final
Map<TopicPartition, OffsetAndMetada
private class OffsetCommitRequestState {
private final Map<TopicPartition, OffsetAndMetadata> offsets;
private final String groupId;
- private final GroupState.Generation generation;
- private final String groupInstanceId;
+ private final Optional<String> memberId;
+ private final Optional<String> groupInstanceId;
private final CompletableFuture<Void> future;
+ private int memberEpoch;
Review Comment:
This should be Optional here too, right? Just as the memberId and
groupInstanceId (groupId is the only required one to be able to commit offsets)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
