jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1183141070
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -3405,6 +3406,52 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES, new
SenderMetricsRegistry(new Metrics(t
assertEquals(1, transactionManager.sequenceNumber(tp1).intValue());
}
+ @Test
+ public void testMakeIllegalTransitionFatal() {
Review Comment:
Is this the change on line 3436? This is useful, but I also wanted to check
that such foreground errors don't poison the state. (ie
transactionManager.hasFatalError is false) Apologies if it was somewhere else
and I missed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
