jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181939941
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -384,14 +436,19 @@ synchronized boolean isAborting() {
}
synchronized void transitionToAbortableError(RuntimeException exception) {
Review Comment:
I think the only concern is that someone uses this method accidentally --
ideally if we add a new place in the code where we transition state, we don't
want to assume it is using the external approach. (I think Philip has a PR that
might incorrectly use this methond.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
