vamossagar12 commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1527739912
@urbandan , i took the liberty and modified the `shutdownExecutorServiceQuietly` to do a 2-phased shutdown as suggested in JavaDocs. Also, modified `MemoryOffsetBackingStore, SourceTaskOffsetCommitter, Worker` to use `shutdownExecutorServiceQuietly` to shutdown their executors. @yashmayya , as suggested, I have also removed the ConnectException thrown from `MemoryOffsetBackingStore#stop`. This is ready for a re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
