vamossagar12 commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1521506051
I checked the flow again and ConnectException being thrown is handled from `AbstractWorkerSourceTask#close` via the `Utils.closeQuietly` method which the Worker#stop doesn't. Nonetheless I agree throwing ConnectException doesn't make sense (although the resource leaks in Worker can still be solved by invoking Utils.closeQuietly.) Regarding the 2 phase stop for ExceutorService, yeah I think we should do it. @urbandan Since you wrote this method WDYT? We are talking about the 2 phase closure example here: https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/concurrent/ExecutorService.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
