vamossagar12 commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1521193360
@yashmayya , hmm MemoryOffsetBackingStore is used in Connect Standalone IIUC. I am not totally aware of the historical context here of whether throwing a ConnectException is valid or not. Do you reckon changing that behaviour is safe? Regarding the shutdown mechanism in Worker, turns out it is what JavaDocs provides as an example https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/concurrent/ExecutorService.html and was pointing out in a code review [here](https://github.com/apache/kafka/pull/11955#discussion_r859425060). Since it's in Worker, I am slightly sceptical in changing this behaviour and also the fact that JavaDocs suggests 2 phase shutdown example. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
