[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

[GitBox]

dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081788435


##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##########
@@ -557,25 +557,25 @@ private[group] class GroupCoordinatorAdapter(
   }
 
   override def onElection(
-    partitionIndex: Int,
-    partitionLeaderEpoch: Int
+    consumerOffsetsPartitionIndex: Int,
+    consumerOffsetsPartitionLeaderEpoch: Int
   ): Unit = {
-    coordinator.onElection(partitionIndex, partitionLeaderEpoch)
+    coordinator.onElection(consumerOffsetsPartitionIndex, 
consumerOffsetsPartitionLeaderEpoch)
   }
 
   override def onResignation(
-    partitionIndex: Int,
-    partitionLeaderEpoch: OptionalInt
+    consumerOffsetsPartitionIndex: Int,
+    consumerOffsetsPartitionLeaderEpoch: OptionalInt
   ): Unit = {
-    coordinator.onResignation(partitionIndex, partitionLeaderEpoch)
+    coordinator.onResignation(consumerOffsetsPartitionIndex, 
consumerOffsetsPartitionLeaderEpoch)
   }
 
-  override def offsetsTopicConfigs(): Properties = {
+  override def consumerOffsetsTopicConfigs(): Properties = {
     coordinator.offsetsTopicConfigs
   }
 
-  override def startup(groupMetadataTopicPartitionCount: IntSupplier): Unit = {
-    coordinator.startup(() => groupMetadataTopicPartitionCount.getAsInt)
+  override def startup(consumerOffsetsPartitionCount: IntSupplier): Unit = {

Review Comment:
   I don't think that we can use `groupMetadataTopic` as prefix everywhere 
because in onElection/onResignation we really want to expression the partition 
index. However, we could use `groupMetadata` as prefix in those cases.
   
   I updated the PR, let me know what you think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org