[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

[GitBox]

dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081571516


##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -3448,7 +3445,7 @@ class KafkaApisTest {
     val expectedJoinGroupResponse = new JoinGroupResponseData()
       .setErrorCode(Errors.INCONSISTENT_GROUP_PROTOCOL.code)
       .setMemberId("member")
-      .setProtocolName(if (version >= 7) null else GroupCoordinator.NoProtocol)
+      .setProtocolName(if (version >= 7) null else 
kafka.coordinator.group.GroupCoordinator.NoProtocol)

Review Comment:
   Yes, we should but I wanted to do this separately because I don't know yet 
where to put them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org