dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081571061
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##########
@@ -511,4 +532,53 @@ class GroupCoordinatorAdapter(
future
}
+
+ override def partitionFor(groupId: String): Int = {
+ coordinator.partitionFor(groupId)
+ }
+
+ override def onTransactionCompleted(
+ producerId: Long,
+ partitions: java.lang.Iterable[TopicPartition],
+ transactionResult: TransactionResult
+ ): Unit = {
+ coordinator.scheduleHandleTxnCompletion(
+ producerId,
+ partitions.asScala,
+ transactionResult
+ )
+ }
+
+ override def onPartitionsDeleted(
+ topicPartitions: util.List[TopicPartition],
+ bufferSupplier: BufferSupplier
+ ): Unit = {
+ coordinator.handleDeletedPartitions(topicPartitions.asScala,
RequestLocal(bufferSupplier))
Review Comment:
We cannot use RequestLocal in the interface because it is part of core.
Therefore, we have to pass the underlying buffer supplier and build
RequestLocal object here. Note that we did this for other apis that we have
merged so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
