cmccabe commented on code in PR #12928:
URL: https://github.com/apache/kafka/pull/12928#discussion_r1036512516


##########
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##########
@@ -50,6 +50,8 @@
     ]
     },
     { "name": "Rack", "type": "string", "versions": "0+", "nullableVersions": 
"0+",
-      "about": "The rack which this broker is in." }
+      "about": "The rack which this broker is in." },
+    { "name": "ZkMigrationReady", "type": "int8", "versions": "0+", 
"taggedVersions": "0+", "tag": 0, "ignorable": true,

Review Comment:
   It would be nice if this name matched up with the field in the broker 
registration.
   
   Maybe something like `IsMigratingZkBroker` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to