cmccabe commented on code in PR #12928:
URL: https://github.com/apache/kafka/pull/12928#discussion_r1036510729
##########
core/src/main/scala/kafka/zk/ZkData.scala:
##########
@@ -56,8 +57,8 @@ import scala.util.{Failure, Success, Try}
object ControllerZNode {
def path = "/controller"
- def encode(brokerId: Int, timestamp: Long): Array[Byte] = {
- Json.encodeAsBytes(Map("version" -> 1, "brokerid" -> brokerId, "timestamp"
-> timestamp.toString).asJava)
+ def encode(brokerId: Int, timestamp: Long, isKRaft: Boolean = false):
Array[Byte] = {
Review Comment:
One thing I was thinking is should we have the `kraftControllerEpoch` here
instead of `isKraft`? Then `kraftControllerEpoch` == -1 (or not present) could
mean ZK mode?
it might help with tracing what was going on...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
