cmccabe commented on code in PR #12928:
URL: https://github.com/apache/kafka/pull/12928#discussion_r1036499024
##########
clients/src/main/resources/common/message/StopReplicaRequest.json:
##########
@@ -24,11 +24,15 @@
// Version 2 is the first flexible version.
//
// Version 3 adds the leader epoch per partition (KIP-570).
- "validVersions": "0-3",
+ //
+ // Version 4 adds KRaft Controller ID field as part of KIP-866
+ "validVersions": "0-4",
"flexibleVersions": "2+",
"fields": [
{ "name": "ControllerId", "type": "int32", "versions": "0+", "entityType":
"brokerId",
"about": "The controller id." },
+ { "name": "KRaftControllerId", "type": "int32", "versions": "4+",
"entityType": "brokerId",
Review Comment:
can we add a default of -1? Also add KIP-866 ref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
