[GitHub] [kafka] showuon commented on a diff in pull request #12305: MINOR: Add __cluster_metadata topic to list of internal topics

[GitBox]

showuon commented on code in PR #12305:
URL: https://github.com/apache/kafka/pull/12305#discussion_r913346863


##########
clients/src/main/java/org/apache/kafka/common/internals/Topic.java:
##########
@@ -33,7 +33,7 @@ public class Topic {
     public static final String LEGAL_CHARS = "[a-zA-Z0-9._-]";
 
     private static final Set<String> INTERNAL_TOPICS = 
Collections.unmodifiableSet(
-            Utils.mkSet(GROUP_METADATA_TOPIC_NAME, 
TRANSACTION_STATE_TOPIC_NAME));
+            Utils.mkSet(GROUP_METADATA_TOPIC_NAME, 
TRANSACTION_STATE_TOPIC_NAME, METADATA_TOPIC_NAME));

Review Comment:
   > We could wrap the code in a conditional check I think
   
   +1, and we should log warning about in ZK mode if the `__cluster_metadata` 
topic exists about the topic will be seen as internal topic after upgrading to 
Kraft mode. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org