[GitHub] [kafka] divijvaidya commented on a diff in pull request #12305: MINOR: Add __cluster_metadata topic to list of internal topics

[GitBox]

divijvaidya commented on code in PR #12305:
URL: https://github.com/apache/kafka/pull/12305#discussion_r901666678


##########
clients/src/main/java/org/apache/kafka/common/internals/Topic.java:
##########
@@ -33,7 +33,7 @@ public class Topic {
     public static final String LEGAL_CHARS = "[a-zA-Z0-9._-]";
 
     private static final Set<String> INTERNAL_TOPICS = 
Collections.unmodifiableSet(
-            Utils.mkSet(GROUP_METADATA_TOPIC_NAME, 
TRANSACTION_STATE_TOPIC_NAME));
+            Utils.mkSet(GROUP_METADATA_TOPIC_NAME, 
TRANSACTION_STATE_TOPIC_NAME, METADATA_TOPIC_NAME));

Review Comment:
   Please correct me if I am wrong here Andy but this is true only for kraft 
mode. I haven't tried it but in the zookeeper mode, it should be possible to 
create a topic with this name as a non-internal topic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org