divijvaidya commented on code in PR #12305:
URL: https://github.com/apache/kafka/pull/12305#discussion_r912780444
##########
clients/src/main/java/org/apache/kafka/common/internals/Topic.java:
##########
@@ -33,7 +33,7 @@ public class Topic {
public static final String LEGAL_CHARS = "[a-zA-Z0-9._-]";
private static final Set<String> INTERNAL_TOPICS =
Collections.unmodifiableSet(
- Utils.mkSet(GROUP_METADATA_TOPIC_NAME,
TRANSACTION_STATE_TOPIC_NAME));
+ Utils.mkSet(GROUP_METADATA_TOPIC_NAME,
TRANSACTION_STATE_TOPIC_NAME, METADATA_TOPIC_NAME));
Review Comment:
> Eventually zk clusters will have to upgrade.
My concern is that if we add this change to the current or upcoming version
(3.3.x), we would break the user who may have a zk cluster with the topic
having this name. @hachikuji Is that breaking change something that we are
willing to accept given that we support zk in these versions? In the interest
of backward compatibility for zk (until it is completely removed), this change
should go in a version where only kraft mode is possible.
We should probably wrap this change in a Raft conditional check, i.e. add
this topic to internal topic list if kraft is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
