guozhangwang commented on code in PR #12337:
URL: https://github.com/apache/kafka/pull/12337#discussion_r911528658
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##########
@@ -697,7 +693,7 @@ private Map<TopicPartition, Long>
committedOffsetForChangelogs(final Map<TaskId,
final
Set<TopicPartition> partitions) {
final Map<TopicPartition, Long> committedOffsets;
try {
- committedOffsets = fetchCommittedOffsets(partitions, mainConsumer);
Review Comment:
I'm thinking that we just ignore the interrupted exception inside the
`StoreChangelogReader`, since when it happens, from the
`StoreChagenlogReader`'s pov we can always just retry in the next loop, and
then if it is due to shutdown we will check the boolean at the beginning of the
iteration and shutdown anyways --- i.e. we may be shutdown a bit later, but
that is consistent with any other possible interruption scenarios, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
