[GitHub] [kafka] dajac commented on a diff in pull request #12337: KAFKA-10199: Remove main consumer from store changelog reader

Wed, 06 Jul 2022 19:47:51 -0700 


dajac commented on code in PR #12337:
URL: https://github.com/apache/kafka/pull/12337#discussion_r915401645


##########
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsOptions.java:
##########
@@ -44,10 +45,21 @@ public ListConsumerGroupOffsetsOptions 
topicPartitions(List<TopicPartition> topi
         return this;
     }
 
+    /**
+     * Sets an optional requireStable flag.
+     */
+    public void requireStable(final boolean requireStable) {
+        this.requireStable = requireStable;
+    }
+
     /**
      * Returns a list of topic partitions to add as part of the result.
      */
     public List<TopicPartition> topicPartitions() {
         return topicPartitions;
     }
+
+    public boolean shouldRequireStable() {

Review Comment:
   Didn’t we settle on using requireStable in the KIP?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to